-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
feat(compiler): compiler supports search and selectedcontent tag #13779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elaborate?
based on #9249, preferably merge that one first and I'll rebase this PR on to it.
related to MananTank/validate-html-nesting#15
closes #13778
see diff compared to #9249: baiwusanyu-c/bwsy-vue-core@bwsy/feat/compilerSearchElm...Calvin-LL:core:calvin/feat/customizable-select
on top of #9249, this adds
selectedcontent
tag and updatedhtmlNesting.ts
according to the description in HTML specs for the following elements to remove the<b> cannot be child of <a>
warnings listed in #13778 and added tests<select>
<optgroup>
<option>
<selectedcontent>