Skip to content

feat(runtime-vapor): hydration with node draft #13798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: minor
Choose a base branch
from

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Aug 24, 2025

Overview

This PR attempts to build Vapor's Hydration architecture based on "ref" and "draft". When hydrating, operations in the Render function will only create drafts and delay actual application until mounting, and update draft nodes to real nodes.

Another attempt to do the Vapor Hydration: #13226

Chart

image

Copy link

coderabbitai bot commented Aug 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 24, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 69.9 kB (+1.3 kB) 26.3 kB (+411 B) 24 kB (+360 B)
createVaporApp 22.2 kB (+1.3 kB) 8.69 kB (+421 B) 7.95 kB (+382 B)
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.5 kB

Copy link

netlify bot commented Aug 24, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 61b8dc0
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68ab55bd63766d000841e2ab

@LittleSound LittleSound mentioned this pull request Aug 24, 2025
23 tasks
Copy link

pkg-pr-new bot commented Aug 24, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13798

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13798

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13798

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13798

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13798

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13798

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13798

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13798

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13798

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13798

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13798

vue

npm i https://pkg.pr.new/vue@13798

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13798

commit: 61b8dc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant