Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use .node-version to maintain node version #8986

Merged
merged 7 commits into from
Oct 20, 2023
+15 −14
Merged

ci: use .node-version to maintain node version #8986

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85c1cc3
ci: define Node version using environment variables
Alfred-Skyblue Aug 16, 2023
5d28f48
ci: update `NODE_VERSION` to `lts/*`
Alfred-Skyblue Aug 21, 2023
d410c2f
chore: merge conflict
Alfred-Skyblue Aug 21, 2023
6d68406
chore: update step name
Alfred-Skyblue Aug 21, 2023
bec6982
ci: use `.node-version` to maintain node version
Alfred-Skyblue Sep 21, 2023
35a495e
Merge branch 'main' into cli-workflows-var
Alfred-Skyblue Oct 20, 2023
c24462a
chore: update node version
Alfred-Skyblue Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/canary.yml
View file
Original file line number Diff line number Diff line change
@@ -17,10 +17,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to 18
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.node-version'
registry-url: 'https://registry.npmjs.org'
cache: 'pnpm'

16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -22,10 +22,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to 18
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.node-version'
cache: 'pnpm'

- run: pnpm install
@@ -44,10 +44,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to 18
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.node-version'
cache: 'pnpm'

- run: pnpm install
@@ -73,10 +73,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to 18
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.node-version'
cache: 'pnpm'

- run: pnpm install
@@ -96,10 +96,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to 18
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.node-version'
cache: 'pnpm'

- run: pnpm install
4 changes: 2 additions & 2 deletions .github/workflows/size-data.yml
View file
Original file line number Diff line number Diff line change
@@ -24,10 +24,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to LTS
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.node-version'
cache: pnpm

- name: Install dependencies
4 changes: 2 additions & 2 deletions .github/workflows/size-report.yml
View file
Original file line number Diff line number Diff line change
@@ -26,10 +26,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2

- name: Set node version to LTS
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.node-version'
cache: pnpm

- name: Install dependencies
1 change: 1 addition & 0 deletions .node-version
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18