Check array/object expressions too

vuejs · Jul 28, 2023 · ce36f18 · ce36f18
1 parent db8717f
commit ce36f18
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 1 deletion.
diff --git a/lib/rules/no-setup-props-destructure.js b/lib/rules/no-setup-props-destructure.js
@@ -35,6 +35,11 @@ module.exports = {
      */
     /** @type {Map<FunctionDeclaration | FunctionExpression | ArrowFunctionExpression | Program, ScopePropsReferences>} */
     const setupScopePropsReferenceIds = new Map()
+    const outerExpressionTypes = new Set([
+      'ArrayExpression',
+      'CallExpression',
+      'ObjectExpression'
+    ])
 
     /**
      * @param {ESNode} node
@@ -63,7 +68,7 @@ module.exports = {
 
       const rightNode = utils.skipChainExpression(right)
 
-      if (rightNode.type === 'CallExpression') {
+      if (outerExpressionTypes.has(rightNode.type)) {
         const propRefs = [...propsReferences.refs.values()]
         const isPropsMemberAccessed = propRefs.some((props) => {
           const isPropsInCallExpression = utils.inRange(rightNode.range, props)

diff --git a/tests/lib/rules/no-setup-props-destructure.js b/tests/lib/rules/no-setup-props-destructure.js
@@ -600,6 +600,66 @@ tester.run('no-setup-props-destructure', rule, {
           line: 5
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      const props = defineProps({ count: Number })
+      const newProps = ref({ count: props.count })
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'getProperty',
+          line: 4
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      const props = defineProps({ count: Number })
+      const counts = [props.count]
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'getProperty',
+          line: 4
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      const props = defineProps({ count: Number })
+      const counter = { count: props.count }
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'getProperty',
+          line: 4
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      const props = defineProps({ count: Number })
+      const counters = [{ count: [props.count] }]
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'getProperty',
+          line: 4
+        }
+      ]
     }
   ]
 })