Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/require-typed-object-prop rule #1983

Merged
merged 29 commits into from
Jul 2, 2023
Merged

Add vue/require-typed-object-prop rule #1983

merged 29 commits into from
Jul 2, 2023

Conversation

przemyslawjanpietrzak
Copy link
Contributor

No description provided.

@FloEdelmann FloEdelmann linked an issue Sep 20, 2022 that may be closed by this pull request
Force TypeScript definition of not primitive props #1655
Closed
@FloEdelmann

This comment was marked as outdated.

Sign in to view
@przemyslawjanpietrzak

This comment was marked as outdated.

Sign in to view
@przemyslawjanpietrzak
Copy link
Contributor Author

@FloEdelmann sorry for the delay, life happened.

I can not fix lint error /home/runner/work/eslint-plugin-vue/eslint-plugin-vue/lib/index.js Warning: 247:5 warning Unexpected 'todo' comment: 'TODO Remove in the next major version' no-warning-comments

I didn't change this file, also I didn't add any todo comments and the branch is synced with the master branch. Can you help me with that

@FloEdelmann
Copy link
Member

No worries. The warning you mentioned is not failing the lint task, but rather the Markdownlint error below:

docs/rules/force-types-on-object-props.md:77 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

@przemyslawjanpietrzak przemyslawjanpietrzak marked this pull request as ready for review February 20, 2023 19:11
FloEdelmann
FloEdelmann requested changes Feb 20, 2023
View reviewed changes
docs/rules/force-types-on-object-props.md Outdated Show resolved Hide resolved
docs/rules/force-types-on-object-props.md Outdated Show resolved Hide resolved
docs/rules/force-types-on-object-props.md Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
tests/lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
tests/lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann changed the title add rule force-types-on-object-props Add force-types-on-object-props rule Feb 20, 2023
FloEdelmann
FloEdelmann requested changes Feb 28, 2023
View reviewed changes
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
tests/lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
@przemyslawjanpietrzak przemyslawjanpietrzak force-pushed the feat/force-types-on-object-props branch 2 times, most recently from 3dd381f to 120a7a8 Compare March 23, 2023 11:28
FloEdelmann
FloEdelmann requested changes Apr 13, 2023
View reviewed changes
docs/rules/force-types-on-object-props.md Outdated Show resolved Hide resolved
docs/rules/force-types-on-object-props.md Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
lib/rules/force-types-on-object-props.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann changed the title Add force-types-on-object-props rule Add vue/require-type-on-object-prop rule Jun 15, 2023
@FloEdelmann FloEdelmann changed the title Add vue/require-type-on-object-prop rule Add vue/require-typed-object-prop rule Jun 21, 2023
FloEdelmann
FloEdelmann approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified and updated the code quite a bit now.
@przemyslawjanpietrzak Could you please check whether it is fine from your side? See https://deploy-preview-1983--eslint-plugin-vue.netlify.app/rules/require-typed-object-prop.html for a preview deployment.

From my side, this would be good to go now.

@przemyslawjanpietrzak
Copy link
Contributor Author

@FloEdelmann yes, looks great :)

ota-meshi
ota-meshi approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this rule! Sorry for the late reply. I am busy with office work.
LGTM!

@ota-meshi ota-meshi merged commit 7f906ea into vuejs:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force TypeScript definition of not primitive props
3 participants
@przemyslawjanpietrzak @FloEdelmann @ota-meshi