Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript declarations for configs #2528

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Shinigami92
Copy link
Contributor

closes #2523

these are really rudimentary, but at least it's a start

@ota-meshi
Copy link
Member

Thank you for this PR! But, I would prefer to rewrite this project in TypeScript.

#2523 (comment)

@Shinigami92
Copy link
Contributor Author

I just want to inform you and other potential contributors that I do not have the capacity to rewrite eslint-plugin-vue to TypeScript
So please merge or reject this PR
and you or another contributor can start tackling the rewrite

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to release d.ts for now.
Thank you for this pull request.

@ota-meshi ota-meshi merged commit 3157fad into vuejs:master Sep 12, 2024
18 checks passed
@Shinigami92 Shinigami92 deleted the issue-2523 branch September 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript declarations for configs
2 participants