Add support for props destructure to vue/require-valid-default-prop rule
#2551
+209
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
FloEdelmann
approved these changes
Sep 17, 2024
| @@ -259,8 +257,7 @@ ruleTester.run('require-valid-default-prop', rule, { | |||
| parser: require('@typescript-eslint/parser'), | |||
| ecmaVersion: 6, | |||
| sourceType: 'module' | |||
| }, | |||
| errors: errorMessage('function') | |||
| } | |||
There was a problem hiding this comment.
These changes are not really related to your changes, right? It was just missed before and you cleaned it up here?
|
I think default values for arrays and objects are handled slightly differently when using props destructuring. I don't believe it's necessary to use a function to construct them, as shown in the example in https://vuejs.org/api/sfc-script-setup.html#reactive-props-destructure: interface Props {
msg?: string
labels?: string[]
}
const { msg = 'hello', labels = ['one', 'two'] } = defineProps<Props>()I've opened an issue: #2578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
vue/require-valid-default-proprule to add support for props destructure.related to #2121