Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type declarations for configs #2566

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

thor-juhasz
Copy link
Contributor

@thor-juhasz thor-juhasz commented Sep 26, 2024

Adds proper types for the configs (in the yet unreleased index.d.ts).

If this PR gets rejected, note that the configs key is still incorrectly typed with the current index.d.ts file.

If only a fix for that is wanted, without the types for the configs themselves, consider this:

  configs: {
-    [name in keyof ConfigName]: any
+    [name in ConfigName]: any
  }

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! 🙂

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit ba6a1d4 into vuejs:master Oct 11, 2024
18 checks passed
@thor-juhasz thor-juhasz deleted the fix-typings branch October 15, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants