Skip to content

fix: add support for jsx camel case event binding #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: add support for jsx camel case event binding #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/babel-plugin-transform-vue-jsx/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,15 @@ const parseAttributeJSXAttribute = (t, path, attributes, tagName, elementType) =

prefix = prefixes.find(el => name.startsWith(el)) || 'attrs'
name = name.replace(new RegExp(`^${prefix}\-?`), '')
name = name[0].toLowerCase() + name.substr(1)

// in jsx, event binding use Camel case, such as `onClick`, `onMouseDown`;
// in HTML Specification, event binding is all lower case, such as `onclick`, `onmousedown`
// so for `on` and `nativeOn` attribute in jsx, transform `name` to all lower case
if (prefix === 'on' || prefix === 'nativeOn') {
name = name.toLowerCase()
} else {
name = name[0].toLowerCase() + name.substr(1)
}

const valuePath = path.get('value')
let value
Expand Down