Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): use unjs/unbuild for bundling #4998

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
4362e9c
chore: use unbuild
kermanx Nov 8, 2024
0f72495
fix
kermanx Nov 8, 2024
6c064d2
chore: remove scripts/build.js
kermanx Nov 8, 2024
575099a
Merge branch 'master' into chore/use-unbuild
kermanx Nov 8, 2024
0d16758
fix: .vscodeignore
kermanx Nov 8, 2024
6f1b173
fix
kermanx Nov 8, 2024
cdc604e
chore: update
kermanx Nov 8, 2024
46a38bd
add sonda report
kermanx Nov 9, 2024
13daf63
fix
kermanx Nov 9, 2024
2b9f8c4
chore: update
kermanx Nov 12, 2024
e0ab5f9
Merge branch 'master' into chore/use-unbuild
kermanx Dec 15, 2024
9f9a758
chore: update
kermanx Dec 15, 2024
fc2416d
fix
kermanx Dec 15, 2024
d377ade
chore: rename `vscode.js` to `vscode-dev-shim.js`
kermanx Dec 15, 2024
02af765
chore: update
kermanx Dec 15, 2024
516e1b6
fix: should build vue-typescript-plugin-pack
kermanx Dec 15, 2024
7868ce6
fix: use .ts as entry
kermanx Dec 15, 2024
3a180c7
chore: update sonda
kermanx Dec 15, 2024
5764d83
fix!!!
kermanx Dec 17, 2024
2887372
Merge branch 'master' into chore/use-unbuild
kermanx Dec 17, 2024
0460fbc
Merge branch 'master' into pr/4998
johnsoncodehk Dec 18, 2024
af30711
Update pnpm-lock.yaml
johnsoncodehk Dec 18, 2024
e64ff70
refactor(language-service): process references data at runtime to red…
KazariEX Dec 18, 2024
9b11d91
Merge branch 'master' into pr/4998
johnsoncodehk Dec 18, 2024
b3235c9
use `rollup-plugin-visualizer` instead of `sonda`
kermanx Dec 18, 2024
ef6c85d
Merge branch 'master' into pr/4998
johnsoncodehk Dec 18, 2024
866159b
Merge branch 'master' into chore/use-unbuild
kermanx Dec 18, 2024
b17e82d
Merge branch 'chore/use-unbuild' of https://github.com/KermanX/vuejs-…
kermanx Dec 18, 2024
6eceeb6
Merge branch 'master' of https://github.com/vuejs/language-tools into…
kermanx Dec 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: use unbuild
kermanx committed Nov 8, 2024
commit 4362e9c078faa88b25f9bc5e776f969eaeb68e4a
2 changes: 2 additions & 0 deletions extensions/vscode/.vscodeignore
Original file line number Diff line number Diff line change
@@ -4,3 +4,5 @@ src
tsconfig.*
meta.json
stats.html
dist/*.mjs
dist/*.d.ts
79 changes: 79 additions & 0 deletions extensions/vscode/build.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import { defineBuildConfig } from "unbuild";
import { fileURLToPath } from "url";

const __dirname = fileURLToPath(new URL(".", import.meta.url));

export default defineBuildConfig([
// {
// entries: [
// {
// builder: "rollup",
// input: "src/nodeClientMain.ts",
// name: "client",
// },
// ],

// outDir: "dist",

// externals: ["vscode"],

// rollup: {
// emitCJS: true,
// },

// stubOptions: {
// jiti: {
// nativeModules: ["typescript", "vscode"],
// alias: {
// vscode: join(__dirname, "vscode.js"),
// },
// },
// },

// hooks: {
// "build:done"(ctx) {
// if (ctx.options.stub) {
// // Patch the stub file
// const stubFilePath = join(__dirname, "dist/client.cjs");
// const originalStub = readFileSync(stubFilePath, "utf-8");
// const newStub = [
// `globalThis.__VOLAR_DEV_VSCODE__ = require('vscode');`,
// `globalThis.__VOLAR_DEV_FS__ = require('node:fs');`,
// originalStub,
// ].join("\n");
// writeFileSync(stubFilePath, newStub);
// }
// },
// },
// },
{
entries: [
{
builder: "rollup",
input: "./node_modules/@vue/language-server/node.ts",
name: "server",
},
{
builder: 'copy',
input: './node_modules/@vue/language-core/schemas',
outDir: './dist/schemas',
}
],

rollup: {
emitCJS: true,
esbuild: {
minify: true,
},
},


externals: [],

// hooks: {
// 'rollup:options'(ctx,options) {
// console.log(options.treeshake)
// }
// }
}
]);
5 changes: 0 additions & 5 deletions extensions/vscode/client.js

This file was deleted.

9 changes: 5 additions & 4 deletions extensions/vscode/package.json
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@
"onLanguage:markdown",
"onLanguage:html"
],
"main": "./client.js",
"main": "./dist/client.cjs",
"browser": "./web.js",
"capabilities": {
"virtualWorkspaces": {
@@ -543,10 +543,10 @@
]
},
"scripts": {
"prebuild": "pnpm run postinstall && pnpm -C ../.. run build",
"build": "node scripts/build",
"__prebuild": "pnpm run postinstall && pnpm -C ../.. run build",
"build": "unbuild",
"build:minify": "pnpm run build -- --minify",
"watch": "pnpm run build -- --watch",
"dev": "unbuild --stub",
"pack": "pnpm run build:minify && vsce package",
"pack:next": "pnpm run build && vsce package",
"release": "pnpm run build:minify && vsce publish",
@@ -567,6 +567,7 @@
"esbuild-visualizer": "latest",
"reactive-vscode": "0.2.7-beta.1",
"semver": "^7.5.4",
"unbuild": "^3.0.0-rc.11",
"vscode-ext-gen": "^0.5.0",
"vscode-tmlanguage-snapshot": "latest"
}
5 changes: 0 additions & 5 deletions extensions/vscode/server.js

This file was deleted.

4 changes: 2 additions & 2 deletions extensions/vscode/src/nodeClientMain.ts
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ export const { activate, deactivate } = defineExtension(async () => {
}
}

let serverModule = vscode.Uri.joinPath(context.extensionUri, 'server.js');
let serverModule = vscode.Uri.joinPath(context.extensionUri, 'dist/server.cjs');

const runOptions: lsp.ForkOptions = {};
if (config.server.maxOldSpaceSize) {
@@ -142,7 +142,7 @@ try {
});

// @ts-expect-error
fs.readFileSync = (...args) => {
(globalThis.__VOLAR_DEV_FS__ || fs).readFileSync = (...args) => {
if (args[0] === extensionJsPath) {
// @ts-expect-error
let text = readFileSync(...args) as string;
1 change: 1 addition & 0 deletions extensions/vscode/vscode.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = globalThis.__VOLAR_DEV_VSCODE__
1,164 changes: 1,147 additions & 17 deletions pnpm-lock.yaml

Large diffs are not rendered by default.