Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow undefined path in router resolve #1909

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

posva
Copy link
Member

@posva posva commented Jul 2, 2023

From #1904

Still need to check if we can avoid the path?: undefined in newer versions of TS.

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit cb10d80
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/657c6298ce062d0008b470a8

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #1909 (962c4d2) into main (2e93d4b) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1909   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          24       24           
  Lines        1117     1117           
  Branches      348      348           
=======================================
  Hits         1014     1014           
  Misses         63       63           
  Partials       40       40           
Impacted Files Coverage Δ
packages/router/src/types/index.ts 100.00% <ø> (ø)
packages/router/src/errors.ts 91.66% <100.00%> (ø)
packages/router/src/matcher/index.ts 98.75% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@posva posva force-pushed the fix-types-path-undefined branch from 3bac392 to 962c4d2 Compare July 5, 2023 13:01
@posva posva merged commit 3b060f6 into main Dec 15, 2023
6 checks passed
@posva posva deleted the fix-types-path-undefined branch December 15, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants