Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): reorder exports in package.json #2323

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

serkodev
Copy link
Contributor

@serkodev serkodev commented Aug 1, 2024

In the exports of package.json, place the . entry higher than ./auto-routes and ./auto.
This can prevent ./auto-routes and ./auto from overriding . in certain import scenarios.

Reference

Within the "exports" object, key order is significant. During condition matching, earlier entries have higher priority and take precedence over later entries. The general rule is that conditions should be from most specific to least specific in object order.

https://nodejs.org/api/packages.html#conditional-exports

Related Links

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 7954813
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/66abaa3ce187df0009a39833

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (001dd51) to head (7954813).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2323   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          26       26           
  Lines        6013     6013           
  Branches      819      819           
=======================================
  Hits         5852     5852           
  Misses        159      159           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 7422b15 into vuejs:main Aug 1, 2024
6 checks passed
@zzpmaster
Copy link

@posva Do you have any plans for releasing a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants