Skip to content

Custom Route Resolvers #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

Custom Route Resolvers #2415

wants to merge 69 commits into from

Conversation

posva
Copy link
Member

@posva posva commented Dec 5, 2024

New version of the internal matcher (renamed as resolver). With more responsibilities and allowing it to be overridden:

  • custom parsing /serializing of params (numbers, dates, classes, etc)
  • matching on the query

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 26bb388
🔍 Latest deploy log https://app.netlify.com/projects/vue-router/deploys/688b9a4531ffa8000881979c

Copy link

pkg-pr-new bot commented Dec 5, 2024

Open in StackBlitz

npm i https://pkg.pr.new/vue-router@2415

commit: 26bb388

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

❌ Patch coverage is 41.52000% with 731 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.89%. Comparing base (6a11243) to head (26bb388).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/experimental/router.ts 0.00% 619 Missing and 1 partial ⚠️
...rc/experimental/route-resolver/resolver-dynamic.ts 86.20% 28 Missing ⚠️
...c/experimental/route-resolver/resolver-abstract.ts 39.53% 26 Missing ⚠️
...src/experimental/route-resolver/resolver-static.ts 79.52% 26 Missing ⚠️
...experimental/route-resolver/matchers/test-utils.ts 79.16% 15 Missing ⚠️
...imental/route-resolver/matchers/matcher-pattern.ts 88.37% 10 Missing ⚠️
...src/experimental/route-resolver/matchers/errors.ts 54.54% 5 Missing ⚠️
packages/router/src/experimental/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2415       +/-   ##
===========================================
- Coverage   94.90%   78.89%   -16.01%     
===========================================
  Files          34       42        +8     
  Lines        3002     4189     +1187     
  Branches      846      956      +110     
===========================================
+ Hits         2849     3305      +456     
- Misses        150      879      +729     
- Partials        3        5        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@posva posva changed the title New Matcher with param parsing Custom Route Resolvers Mar 20, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triaging in Vue Router Roadmap Jul 15, 2025
@posva posva moved this from 🆕 Triaging to 🧑‍💻 In progress in Vue Router Roadmap Jul 15, 2025
@posva posva mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧑‍💻 In progress
Development

Successfully merging this pull request may close these issues.

1 participant