-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: text() misses content for array functional component #2579
fix: text() misses content for array functional component #2579
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@cexbrayat This is an initial idea to fix #2568, all tests are passing but I hacked a bit around the types and method signatures. I'll need help to get those fixed ;) I am also not sure if changing the cc @xanf |
b03d208
to
d2b4fbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miguelrincon for the PR, sorry it took us so long to review.
This looks like a nice fix to the issue, I think we can go ahead. Can your rebase the PR and maybe remove the comment about any
? I think we're OK if we leave any
there.
d2b4fbc
to
03f0a56
Compare
03f0a56
to
3c50e67
Compare
@cexbrayat Thanks for the response. I removed the comment and rebased. Can you have another look? |
@miguelrincon It looks like the linter in unhappy, can you take a look? thank you! |
3c50e67
to
4bfd721
Compare
@cexbrayat can you have one more look? |
Thank you ! |
@cexbrayat Thanks for merging. I see the last release, 2.4.6, was quite some time ago. Do you plan to create a new release anytime soon? |
We will (I don't have the publishing rights so I need help from someone else, who I'll ping when Vue v3.6 is out). |
Fix for #2568
This change adds a new optional parameter to the DOMWrapper constructor so information about its structure can be later used to produce correct
text()
andhtml()
assertions.