Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text() misses content for array functional component #2579

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

miguelrincon
Copy link
Contributor

Fix for #2568

This change adds a new optional parameter to the DOMWrapper constructor so information about its structure can be later used to produce correct text() and html() assertions.

@miguelrincon miguelrincon marked this pull request as draft December 31, 2024 14:32
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 4bfd721
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/67cedb8337e5050008bdf3cd
😎 Deploy Preview https://deploy-preview-2579--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@miguelrincon
Copy link
Contributor Author

@cexbrayat This is an initial idea to fix #2568, all tests are passing but I hacked a bit around the types and method signatures. I'll need help to get those fixed ;)

I am also not sure if changing the DOMWrapper constructor to take a vnode it's a better fit, as the vnode contains more information we may need (rather than just the new subtree param), seems like a bigger change than I'd like to take on.

cc @xanf

@miguelrincon miguelrincon force-pushed the 2568-fix-func-component-array branch from b03d208 to d2b4fbc Compare December 31, 2024 14:38
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miguelrincon for the PR, sorry it took us so long to review.

This looks like a nice fix to the issue, I think we can go ahead. Can your rebase the PR and maybe remove the comment about any? I think we're OK if we leave any there.

@miguelrincon miguelrincon force-pushed the 2568-fix-func-component-array branch from d2b4fbc to 03f0a56 Compare March 7, 2025 22:43
@miguelrincon miguelrincon marked this pull request as ready for review March 7, 2025 22:44
@miguelrincon miguelrincon force-pushed the 2568-fix-func-component-array branch from 03f0a56 to 3c50e67 Compare March 7, 2025 22:45
@miguelrincon
Copy link
Contributor Author

@cexbrayat Thanks for the response. I removed the comment and rebased. Can you have another look?

@cexbrayat
Copy link
Member

@miguelrincon It looks like the linter in unhappy, can you take a look? thank you!

@miguelrincon miguelrincon force-pushed the 2568-fix-func-component-array branch from 3c50e67 to 4bfd721 Compare March 10, 2025 12:30
@miguelrincon
Copy link
Contributor Author

@cexbrayat can you have one more look? prettier should be happier now.

@cexbrayat cexbrayat merged commit 5ac39ac into vuejs:main Mar 10, 2025
7 checks passed
@cexbrayat
Copy link
Member

Thank you !

@miguelrincon
Copy link
Contributor Author

@cexbrayat Thanks for merging. I see the last release, 2.4.6, was quite some time ago. Do you plan to create a new release anytime soon?

@cexbrayat
Copy link
Member

We will (I don't have the publishing rights so I need help from someone else, who I'll ping when Vue v3.6 is out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants