fix(theme): avoid layout shift caused by scrollbar #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqianem
force-pushed
the
fix-layout-shifts
branch
from
6656584
to
e8587e8
Compare
4 tasks
zqianem
force-pushed
the
fix-layout-shifts
branch
from
e8587e8
to
5a6a02e
Compare
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
7ad4a4e
to
f0d3082
Compare
Lehoczky
approved these changes
Aug 6, 2023
zqianem
added a commit
to zqianem/vitepress-python-editor
that referenced
this pull request
May 11, 2024
Applies some upstream VitePress patches: - vuejs/vitepress#1844 - vuejs/vitepress#3879
|
I recently applied this patch (along with others) to the latest version of VitePress (1.2.2) for a project of mine and can confirm the fix still works well. @brc-dd I am still interested in getting this PR merged — is there anything else I can do to help that process along? The only potentially problematic thing I can see for this patch is the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1054
Same as #1568 which was mistakenly closed by me.