-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme-default): Support centering members in VPTeamPage #3796
base: main
Are you sure you want to change the base?
Conversation
Gonna look into this. Needs a bit adjustment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try use idicomatic css writing to your styles, it's so good ✌️https://github.com/necolas/idiomatic-css
I've updated a few things.
@brc-dd |
@kiaking When there are more than 3 members on the page and the width is large, it is always displayed in two columns. |
Oh no 😅 Thanks! I'll fix it. |
OK, now I think I've fixed. I went and separated small and medium size styles completely since mixing them up was mixing up my brain 😅 |
Thank you! 😉 But there may be some problems:
|
Oh no... thank you for keep testing! I'll continue look into it. Yeah I wasn't testing in home layout too, but not sure why it makes any difference... 🤔 |
Thanks for the commit. ❤️You don't have to say thank you to me, I filed an issue (#3769) and then fixed it, and it's my responsibility to do that too. Since I don't know any more details, thank you for taking the time to help me refine this PR. ❤️ |
Todo
team-test.md
before merging.preview
Please click to view the screenshot
small
medium
fixed: #3769