feat: Improve Sidebar and Aside Link Visibility on Mount and Route Change #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize the `aside-container` to update scroll behavior when the `activeLink` is out of the viewport.
Automatically scrolls to ensure the active sidebar link is in view upon page load. Co-Authored-By: Bobbie Goede <[email protected]>
Ensures the sidebar link visibility is maintained not only on page load, but also when the route changes.
shellRaining
reviewed
Jul 8, 2024
| } else { | ||
| marker.value.style.top = '33px' | ||
| marker.value.style.opacity = '0' | ||
| aside.value.scrollTop = 0 |
There was a problem hiding this comment.
Hello, may I ask what this line of code is doing? I saw in the developer tools that the aside itself does not generate a scroll bar, so scrollTop remains 0 all the time. Can this piece of code and related parts be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces enhancements to the sidebar and aside navigation in the default theme. It ensures that the active sidebar link is always visible to the user, both when the page loads and when the route changes.
fixes #3351 is this one a duplicate of #3000 ?
fixes #3426
p.s: I opened this pr because I can't change the #3654 one and it needs rebase