fix(theme): respect custom tag prop in VPButton component #4185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the VPButton component of the default VitePress theme. Previously, the
tag
prop was not being properly respected when determining the component to render. This change ensures that thetag
prop takes precedence, falling back toa
orbutton
based on the presence of thehref
prop only if no custom tag is specified.Here's a simple script that demonstrates the effect of this change:
In this example, even though we specify a custom tag 'div' and there's no href, the original code would incorrectly choose 'a'. The fixed version correctly respects the custom tag 'div'.
Linked Issues
None.
Additional Context
None.
Tip
The author of this PR can publish a preview release by commenting
/publish
below.