Enhanced RTL support#5071
Conversation
…nce path normalization by cleaning invisible characters.
|
/publish |
|
/publish |
commit: |
|
Here some hints using UnoCSS (should be easy to translate to plain css) : https://github.com/elk-zone/elk/blob/main/CONTRIBUTING.md#rtl-support Check also if we need to add flip support for icons: https://github.com/elk-zone/elk/blob/371aa5c469b1e025f80c887f5ea18ecccf983129/app/styles/global.css#L203-L205 (at elk.zone we have the elk logo and we flip the elk header https://github.com/elk-zone/elk/blob/main/public/logo.svg on rtl) |
current theme styling does not use UnoCSS, also flip icons done |
…r directional icons and applying it to external link icons.
|
/publish |
|
I think now it is ready |
|
can you add/enable the rtl to this lang on docs? https://github.com/vuejs/vitepress/tree/main/docs/fa upps look like it is fine (should be configured at locales entry), shouldn't we add the flip to the hero image or just change the angle? |
|
We also need to change the layout for the selectors, arrow down shouldn't be on the right? /cc @brc-dd where is the pr docs preview? Found, just clicking on the deploy/netlify link: https://deploy-preview-5071--vitepress-docs.netlify.app/fa/ Check version and lang switcher:
|
You're right, review the menu button on narrow screen I think it should be flipped. |
It should display the same text inside the <time>, we use lang in the browser, the problem when some punctuation present inside the time. |
|
/publish |
it is ready |
|
/publish |
|
This PR is duplicate of #5034 |
|
|
||
| provide(layoutInfoInjectionKey, { heroImageSlotExists }) | ||
|
|
||
| watchEffect(() => { |
There was a problem hiding this comment.
This should be used also on ssr, generated html pages should have the dir attr at build time and at runtime.
Maybe this is not the best place to change html dir attr, we should move it to client/app/index.ts (already included for lean at client spa but we should also check if we should add it for ssr):
https://github.com/vuejs/vitepress/blob/main/src/client/app/index.ts#L47
I'll take a look. The approach of both PRs look similar though. 👀 Probably can keep both / parts of both. |
15a0278 to
09af6c7
Compare
Co-authored-by: Rami Yushuvaev <92088692+rami-elementor@users.noreply.github.com>
Co-authored-by: Rami Yushuvaev <92088692+rami-elementor@users.noreply.github.com>
Co-authored-by: Rami Yushuvaev <92088692+rami-elementor@users.noreply.github.com>
Co-authored-by: Rami Yushuvaev <92088692+rami-elementor@users.noreply.github.com>









Description
change default theme to use logical properties, and enhance URL matching
Linked Issues
~
Additional Context
~