-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cssModules): namedExport support #1909
base: main
Are you sure you want to change the base?
Conversation
b271eb9
to
7c3fd0e
Compare
7c3fd0e
to
d3ca9f8
Compare
3cdd2be
to
30d2938
Compare
30d2938
to
855ca04
Compare
855ca04
to
98c07b1
Compare
98c07b1
to
34f4ecf
Compare
34f4ecf
to
40c92bd
Compare
40c92bd
to
3a61ba2
Compare
For v17 Support css-loader : `options.modules.namedexport` https://github.com/webpack-contrib/css-loader/tree/v4.3.0#namedexport https://github.com/webpack-contrib/css-loader#namedexport feat(cssModules ): namedExport support
3a61ba2
to
a6b387b
Compare
Hi everyone, I'm very interested by this PR for letting us upgrade css-loader from v6 to v7 in webpack Encore, see symfony/webpack-encore#1319 What is the state of this PR, is there anything else to do before reviewing/merging/releasing? |
To be honest, I don't fully understand all the codes of Since the release of If anyone would like to push forward with the merging of this feature, or help improve the reliability of the code, I would be very grateful. |
Thanks for your work!
Yeah I understand, that's what I am afraid of too when I see no releases for ~10 months :/ FYI In Encore context, I think we will take the decision to force the user to configure |
For v17
Support css-loader :
options.modules.namedexport
https://github.com/webpack-contrib/css-loader/tree/v4.3.0#namedexport
https://github.com/webpack-contrib/css-loader#namedexport
Fix: #1788, #1794, #1709, #1612, #1866