Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cssModules): namedExport support #1909

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Airkro
Copy link

@Airkro Airkro commented Dec 16, 2021

@Airkro Airkro force-pushed the feat/css-modules-named-export branch from b271eb9 to 7c3fd0e Compare May 9, 2023 08:19
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 7c3fd0e to d3ca9f8 Compare May 17, 2023 02:06
@Airkro Airkro force-pushed the feat/css-modules-named-export branch 2 times, most recently from 3cdd2be to 30d2938 Compare May 30, 2023 04:05
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 30d2938 to 855ca04 Compare June 27, 2023 01:56
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 855ca04 to 98c07b1 Compare October 17, 2023 02:12
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 98c07b1 to 34f4ecf Compare November 1, 2023 03:42
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 34f4ecf to 40c92bd Compare January 2, 2024 03:16
@Airkro Airkro changed the title feat(cssModules ): namedExport support feat(cssModules): namedExport support Apr 25, 2024
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 40c92bd to 3a61ba2 Compare April 25, 2024 01:26
@Airkro Airkro force-pushed the feat/css-modules-named-export branch from 3a61ba2 to a6b387b Compare July 15, 2024 03:27
@Kocal
Copy link

Kocal commented Sep 20, 2024

Hi everyone, I'm very interested by this PR for letting us upgrade css-loader from v6 to v7 in webpack Encore, see symfony/webpack-encore#1319

What is the state of this PR, is there anything else to do before reviewing/merging/releasing?
Thanks! 🙏🏻

@Airkro
Copy link
Author

Airkro commented Sep 21, 2024

To be honest, I don't fully understand all the codes of vue-loader, but this PR can pass basic tests, has been released as @best-shot/vue-loader, and has supported multiple projects of the company I work for for many years. It is practically usable.

Since the release of vite, the official has only provided basic vue-loader support for many years, refusing to add any additional features and fixes. Given the official Vue's neglect of the webpack ecosystem, I have almost given up the possibility of it being merged.

If anyone would like to push forward with the merging of this feature, or help improve the reliability of the code, I would be very grateful.

@Kocal
Copy link

Kocal commented Sep 22, 2024

To be honest, I don't fully understand all the codes of vue-loader, but this PR can pass basic tests, has been released as @best-shot/vue-loader, and has supported multiple projects of the company I work for for many years. It is practically usable.

Thanks for your work!
However, for a package such as Symfony Webpack Encore, I am not fan of replacing the official vue-loader by an external (or even internal) fork, that would condemn the project more quickly. Also, I don't know the position of Symfony about forks, but I think it would be very similar.

Since the release of vite, the official has only provided basic vue-loader support for many years, refusing to add any additional features and fixes. Given the official Vue's neglect of the webpack ecosystem, I have almost given up the possibility of it being merged.

Yeah I understand, that's what I am afraid of too when I see no releases for ~10 months :/

FYI In Encore context, I think we will take the decision to force the user to configure css-loader to not use named export if they use Vue.js + CSS Modules, since React/Preact + CSS modules users are not stuck because this kind of issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS modules documentation uses invalid css-loader options object
2 participants