Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

fix(runtime-vapor): current instance is not attached to static slots - #247

Merged
sxzz merged 3 commits into
mainfrom
fix/attach-current-instance-to-render-slot
Jun 20, 2024
Merged

fix(runtime-vapor): current instance is not attached to static slots#247
sxzz merged 3 commits into
mainfrom
fix/attach-current-instance-to-render-slot

Conversation

@LittleSound

Copy link
Copy Markdown
Member

related #168

When all slots are static slots, it is also necessary to call withCtx to attach the current instance to the slots.

@netlify

netlify Bot commented Jun 20, 2024

Copy link
Copy Markdown

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 9a38c1f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/667421408252ba0008e0064d
😎 Deploy Preview https://deploy-preview-247--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jun 20, 2024

Copy link
Copy Markdown

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 9a38c1f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/667421400bbda10008d8fc39
😎 Deploy Preview https://deploy-preview-247--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions

github-actions Bot commented Jun 20, 2024

Copy link
Copy Markdown

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.2 kB 28.5 kB 25.1 kB
compiler-vapor.global.prod.js 57.6 kB 19.6 kB 17.7 kB
runtime-dom.global.prod.js 95.4 kB 36 kB 32.4 kB
runtime-vapor.global.prod.js 48.9 kB (+39 B) 18.3 kB (+16 B) 16.7 kB (+14 B)
vue-vapor.global.prod.js 104 kB (+39 B) 36.3 kB (+18 B) 32.7 kB (+23 B)
vue.global.prod.js 154 kB 55.6 kB 49.7 kB

Usages

Name Size Gzip Brotli
createApp 55.8 kB 21.4 kB 19.5 kB
createSSRApp 59.1 kB 22.7 kB 20.7 kB
defineCustomElement 58.1 kB 22.1 kB 20.1 kB
vapor 49.3 kB (+39 B) 18.3 kB (+15 B) 16.7 kB (+13 B)
overall 69.6 kB 26.4 kB 23.9 kB

Comment thread packages/runtime-vapor/src/componentSlots.ts Outdated
Comment thread packages/runtime-vapor/src/componentSlots.ts Outdated
@sxzz
sxzz merged commit 7d90c88 into main Jun 20, 2024
@sxzz
sxzz deleted the fix/attach-current-instance-to-render-slot branch June 20, 2024 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants