Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-vapor): current instance is not attached to static slots #247

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

LittleSound
Copy link
Member

related #168

When all slots are static slots, it is also necessary to call withCtx to attach the current instance to the slots.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 9a38c1f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/667421408252ba0008e0064d
😎 Deploy Preview https://deploy-preview-247--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 9a38c1f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/667421400bbda10008d8fc39
😎 Deploy Preview https://deploy-preview-247--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jun 20, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.2 kB 28.5 kB 25.1 kB
compiler-vapor.global.prod.js 57.6 kB 19.6 kB 17.7 kB
runtime-dom.global.prod.js 95.4 kB 36 kB 32.4 kB
runtime-vapor.global.prod.js 48.9 kB (+39 B) 18.3 kB (+16 B) 16.7 kB (+14 B)
vue-vapor.global.prod.js 104 kB (+39 B) 36.3 kB (+18 B) 32.7 kB (+23 B)
vue.global.prod.js 154 kB 55.6 kB 49.7 kB

Usages

Name Size Gzip Brotli
createApp 55.8 kB 21.4 kB 19.5 kB
createSSRApp 59.1 kB 22.7 kB 20.7 kB
defineCustomElement 58.1 kB 22.1 kB 20.1 kB
vapor 49.3 kB (+39 B) 18.3 kB (+15 B) 16.7 kB (+13 B)
overall 69.6 kB 26.4 kB 23.9 kB

@sxzz sxzz merged commit 7d90c88 into main Jun 20, 2024
11 checks passed
@sxzz sxzz deleted the fix/attach-current-instance-to-render-slot branch June 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants