Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-vapor): add beforeUpdate hook for custom directive #66

Closed
wants to merge 4 commits into from
Closed

feat(runtime-vapor): add beforeUpdate hook for custom directive #66

wants to merge 4 commits into from

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Dec 15, 2023 •
edited
Loading

close #65

By the way, I adjusted the trigger timing of the updated hook to after the effect in the render function.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 88.2 kB 33.6 kB 30.3 kB
runtime-vapor.global.prod.js 20.4 kB (+291 B) 7.76 kB (+88 B) 7.14 kB (+96 B)
vue-vapor.global.prod.js 55.9 kB (+291 B) 18.9 kB (+94 B) 17.1 kB (+133 B)
vue.global.prod.js 145 kB 52.7 kB 47.1 kB

Usages

Name Size Gzip Brotli
createApp 48.8 kB 19.1 kB 17.5 kB
createSSRApp 52 kB 20.5 kB 18.7 kB
defineCustomElement 51.2 kB 19.9 kB 18.2 kB
vapor 20.3 kB (+291 B) 7.78 kB (+96 B) 7.14 kB (+81 B)
overall 62.2 kB 24 kB 21.9 kB

@LittleSound LittleSound marked this pull request as ready for review December 15, 2023 16:55
sxzz
sxzz reviewed Dec 16, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to implement watchEffect first this PR. See doWatch in runtime-core package.

@sxzz sxzz marked this pull request as draft December 23, 2023 07:24
@LittleSound LittleSound changed the title feat(runtime): add beforeUpdate hook for custom directive feat(runtime-vapor): add beforeUpdate hook for custom directive Jan 7, 2024
@LittleSound
Copy link
Member Author

LittleSound commented Jan 7, 2024 •
edited
Loading

Because it is implemented in #89, close this PR.

@LittleSound LittleSound closed this Jan 7, 2024
@sxzz sxzz deleted the feat/runtime-hook-beforeUpdate branch January 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Runtime] add beforeUpdate hook for custom directive
2 participants
@LittleSound @sxzz