fix(nuxt): give plugins .mjs extension so they're processed
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1479 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 28 28
Lines 3849 3849
Branches 264 264
=======================================
Hits 2873 2873
Misses 976 976 ☔ View full report in Codecov by Sentry. |
|
This ends up breaking in the playground as if the |
|
It was just missing the |
|
oops - sorry! 😬 |
|
No worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuxt/nuxt#24733 is caused by Nuxt not treating
.ejsfiles as JavaScript (and therefore not running certain build plugins on the code within them).We might be able to handle this transparently within Nuxt as well but this PR fixes it in a backwards-compatible way.