-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nested): prevent parent node activate firing for singleLeaf #20951
base: master
Are you sure you want to change the base?
Conversation
packages/vuetify/src/util/helpers.ts
Outdated
@@ -378,11 +378,14 @@ export function filterInputAttrs (attrs: Record<string, unknown>) { | |||
|
|||
/** | |||
* Returns the set difference of B and A, i.e. the set of elements in B but not in A | |||
* A and B can be sets, but the function always returns the result as an array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KaelWD What do you think of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're already sets .has should be faster than .includes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to use symmetricDifference
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use these yet unfortunately: https://caniuse.com/mdn-javascript_builtins_set_symmetricdifference
Description
fixes #20946
Markup: