Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve hairpinning #268

Merged
merged 7 commits into from
Aug 19, 2024
Merged

resolve hairpinning #268

merged 7 commits into from
Aug 19, 2024

Conversation

happytreees
Copy link
Contributor

Description

This PR should resolve issues with hairpinning by setting the hostname for the vlb.

Related Issues

CLOUD-4969

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@happytreees happytreees added the enhancement New feature or request label Jul 30, 2024
@happytreees happytreees requested a review from optik-aper July 30, 2024 13:51
@happytreees happytreees self-assigned this Jul 30, 2024
optik-aper
optik-aper previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test and confirm annotations are applied.

@optik-aper optik-aper self-requested a review August 19, 2024 15:00
optik-aper
optik-aper approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@happytreees happytreees merged commit f180da4 into master Aug 19, 2024
4 checks passed
@happytreees happytreees deleted the hairpin-fix branch August 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees

@happytreees happytreees

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@happytreees @optik-aper