Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update govultr from v3.9.1 to v3.11.1 #252

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mondragonfx
Copy link
Contributor

Description

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

Copy link

Unit Tests and Coverage

Show Output
	github.com/vultr/vultr-csi/cmd/csi-vultr-driver		coverage: 0.0%25 of statements%0A=== RUN   TestCreateVolume%0Atime="2024-10-30T16:09:14Z" level=info msg="Create Volume: called" capabilities="[mount:{}  access_mode:{mode:SINGLE_NODE_WRITER}]" test="create volume" volume-name=volume-test-name%0Atime="2024-10-30T16:09:15Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-10-30T16:09:15Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-10-30T16:09:15Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-10-30T16:09:15Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-10-30T16:09:15Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-10-30T16:09:15Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-10-30T16:09:15Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0Acoverage: 27.4%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.006s	coverage: 27.4%25 of statements

Pusher: @mondragonfx, Action: pull_request_target

@optik-aper optik-aper added the clean-up General maintenance of code base label Oct 30, 2024
Copy link

Unit Tests and Coverage

Show Output
	github.com/vultr/vultr-csi/cmd/csi-vultr-driver		coverage: 0.0%25 of statements%0A=== RUN   TestCreateVolume%0Atime="2024-10-30T16:28:48Z" level=info msg="Create Volume: called" capabilities="[mount:{}  access_mode:{mode:SINGLE_NODE_WRITER}]" test="create volume" volume-name=volume-test-name%0Atime="2024-10-30T16:28:49Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-10-30T16:28:49Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-10-30T16:28:49Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-10-30T16:28:49Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-10-30T16:28:49Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-10-30T16:28:49Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-10-30T16:28:49Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0Acoverage: 27.4%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.006s	coverage: 27.4%25 of statements

Pusher: @mondragonfx, Action: pull_request_target

@optik-aper optik-aper added the dependencies Pull requests that update a dependency file label Oct 30, 2024
@optik-aper optik-aper changed the title remove deprecated govultr.PrivateNetwork functions Update govultr from v3.9.1 to v3.11.1 Oct 30, 2024
@optik-aper optik-aper removed the clean-up General maintenance of code base label Oct 30, 2024
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@optik-aper optik-aper merged commit df981ff into vultr:master Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants