fix: welcome onboarding screens now respect theme colors (fixes #1005) #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theme colors (closes #1005) Welcome onboarding screens were displaying white text regardless of theme because Text components lacked the color prop. All body text now uses Colors.Foreground to properly respect theme settings (e.g., green text for Green Screen theme). This fixes the theme violation reported in #1005. Modified components: - WelcomeStep.tsx: Welcome message and prompt text - ProviderSelectStep.tsx: Provider selection prompt - ModelSelectStep.tsx: Model selection prompt - AuthMethodStep.tsx: Authentication method prompt - AuthenticationStep.tsx: OAuth loader and API key prompt - CompletionStep.tsx: Profile summary and saving prompts - SkipExitStep.tsx: Manual setup instructions
github-actions
bot
added
the
maintainer:e2e:ok
Contributor
WalkthroughStyling updates across seven WelcomeOnboarding components apply foreground color to Text elements, ensuring consistent theme-aware text rendering throughout the welcome screen flow without modifying logic or control flow. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧬 Code graph analysis (5)packages/cli/src/ui/components/WelcomeOnboarding/ModelSelectStep.tsx (2)
packages/cli/src/ui/components/WelcomeOnboarding/ProviderSelectStep.tsx (2)
packages/cli/src/ui/components/WelcomeOnboarding/AuthenticationStep.tsx (2)
packages/cli/src/ui/components/WelcomeOnboarding/WelcomeStep.tsx (2)
packages/cli/src/ui/components/WelcomeOnboarding/SkipExitStep.tsx (2)
⏰ Context from checks skipped due to timeout of 270000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
LLxprt PR Review – PR #1030Issue Alignment
Side Effects
Code Quality
Tests & Coverage
Verdict |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-24.x-ubuntu-latest' artifact from the main CI run. |
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed theme violations in all welcome onboarding screens. Text elements that were displaying in white regardless of theme selection now properly respect the theme's
Colors.Foregroundsetting.Problem
When using themes (particularly Green Screen), the welcome onboarding screens displayed white text instead of respecting the theme's foreground color. This happened because
<Text>components lacked thecolorprop, causing Ink to use the terminal's default color (white) instead of the theme'sForegroundcolor.Root Cause
Analysis by CodeRabbit identified that Text components in the welcome onboarding screens were missing the
color={Colors.Foreground}prop, which is required to respect theme settings.Solution
Added
color={Colors.Foreground}to all body text elements across 7 welcome onboarding components:Changes Modified
Testing
Verification
To verify the fix works correctly:
#6a9955) instead of whiteRelated Issue
closes #1005
Summary by CodeRabbit
Style
✏️ Tip: You can customize this high-level summary in your review settings.