-
Notifications
You must be signed in to change notification settings - Fork 88
fix: discover project-scoped memories in .llxprt/ directories during upward scan #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…upward scan The memory discovery upward scan now checks for LLXPRT.md files inside .llxprt/ subdirectories at each directory level, matching how save_memory writes project-scoped memories to .llxprt/LLXPRT.md. This ensures project-scoped memories saved via save_memory with scope: 'project' are reliably discovered and loaded. Closes #985
WalkthroughThe PR adds memory discovery support for project-scoped memory files in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📓 Common learnings🧬 Code graph analysis (1)packages/core/src/utils/memoryDiscovery.ts (1)
⏰ Context from checks skipped due to timeout of 270000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'll analyze this PR that fixes project-scoped memory discovery. Let me start by examining the changes, then provide a structured review. LLxprt PR Review – PR #991Issue Alignment
Side Effects
Code Quality
Tests & Coverage
Verdict |
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-24.x-ubuntu-latest' artifact from the main CI run. |
Summary
Fixes the issue where project-scoped memories saved to
.llxprt/LLXPRT.mdwere not being loaded by the memory discovery system.Problem
When using
save_memorywithscope: 'project', memories are saved to./.llxprt/LLXPRT.md. However, the memory discovery system's upward scan only looked forLLXPRT.mddirectly in directories (e.g.,./LLXPRT.md,../LLXPRT.md), not inside.llxprt/subdirectories.This caused project-scoped memories to not be reliably loaded because:
.llxprt/LLXPRT.mdentirelySolution
Modified the upward scan in
memoryDiscovery.tsto also check forLLXPRT.mdfiles inside.llxprt/subdirectories at each directory level. This ensures project-scoped memories are discovered during the reliable upward traversal, matching the behavior already used for the global memory path (~/.llxprt/LLXPRT.md).Changes
packages/core/src/utils/memoryDiscovery.ts: Added check for.llxprt/LLXPRT.mdin the upward scan looppackages/core/src/utils/memoryDiscovery.test.ts: Added 4 behavioral tests for project-scoped memory discoveryTesting
All 20 memory discovery tests pass, including the 4 new tests:
should discover memory files saved to .llxprt/ subdirectory during upward scanshould discover memory files in .llxprt/ at multiple directory levels during upward scanshould load both direct LLXPRT.md and .llxprt/LLXPRT.md from the same directoryshould not duplicate global memory path when scanning .llxprt/ directoriesCloses #985
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.