Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

T7577: VPP VRRP plugin implementation#56

Closed
natali-rs1985 wants to merge 1 commit intovyos-legacy:currentfrom
natali-rs1985:T7577
Closed

T7577: VPP VRRP plugin implementation#56
natali-rs1985 wants to merge 1 commit intovyos-legacy:currentfrom
natali-rs1985:T7577

Conversation

@natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Jul 30, 2025

CLI commands:
set vpp vrrp group FIRST address <192.0.2.1> # multi
set vpp vrrp group FIRST interface
set vpp vrrp group FIRST vrid <10>
set vpp vrrp group FIRST priority <100>
set vpp vrrp group FIRST peer-address <192.0.2.12> # multi
set vpp vrrp group FIRST advertise-interval <100>
set vpp vrrp group FIRST no-preempt
set vpp vrrp group FIRST accept-mode
set vpp vrrp group FIRST disable
set vpp vrrp group FIRST description

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

Proposed changes

How to test

set interfaces ethernet eth1 address '192.0.2.11/24'
set interfaces ethernet eth1 vif 11 address '10.0.11.1/30'
set interfaces ethernet eth1 vif 12 address '10.0.12.1/30'

set vpp settings interface eth1 driver 'dpdk'
set vpp settings unix poll-sleep-usec '222'

set vpp vrrp group VRRP address '192.0.5.1'
set vpp vrrp group VRRP interface 'eth1'
set vpp vrrp group VRRP vrid '10'

set vpp vrrp group VIF address '10.0.2.2'
set vpp vrrp group VIF interface 'eth1.11'
set vpp vrrp group VIF vrid '50'

vyos@vyos# run show vpp vrrp
Name    Interface      VRID  State      Priority  Address
------  -----------  ------  -------  ----------  ---------
VRRP    eth1             10  MASTER          100  192.0.5.1
VIF     eth1.11          50  MASTER          100  10.0.2.2

vyos@vyos# /usr/libexec/vyos/tests/smoke/cli/test_vpp.py
test_01_vpp_basic (__main__.TestVPP.test_01_vpp_basic) ... ok
test_02_vpp_vxlan (__main__.TestVPP.test_02_vpp_vxlan) ... ok
test_03_vpp_gre (__main__.TestVPP.test_03_vpp_gre) ... ok
test_04_vpp_geneve (__main__.TestVPP.test_04_vpp_geneve) ... skipped 'Skipping this test geneve index always is 0'
test_05_vpp_loopback (__main__.TestVPP.test_05_vpp_loopback) ... ok
test_06_vpp_bonding (__main__.TestVPP.test_06_vpp_bonding) ... skipped 'Skipping temporary bonding, sometimes get recursion T7117'
test_07_vpp_bridge (__main__.TestVPP.test_07_vpp_bridge) ... ok
test_08_vpp_ipip (__main__.TestVPP.test_08_vpp_ipip) ... ok
test_09_vpp_xconnect (__main__.TestVPP.test_09_vpp_xconnect) ... ok
test_10_vpp_driver_options (__main__.TestVPP.test_10_vpp_driver_options) ... ok
test_11_vpp_cpu_settings (__main__.TestVPP.test_11_vpp_cpu_settings) ... ok
test_12_vpp_cpu_corelist_workers (__main__.TestVPP.test_12_vpp_cpu_corelist_workers) ... ok
test_13_1_buffer_page_size (__main__.TestVPP.test_13_1_buffer_page_size) ... ok
test_13_2_statseg_page_size (__main__.TestVPP.test_13_2_statseg_page_size) ... ok
test_13_3_mem_page_size (__main__.TestVPP.test_13_3_mem_page_size) ... skipped 'Skipping ...'
test_14_mem_default_hugepage (__main__.TestVPP.test_14_mem_default_hugepage) ... ok
test_15_vpp_ipsec_xfrm_nl (__main__.TestVPP.test_15_vpp_ipsec_xfrm_nl) ... ok
test_16_vpp_cgnat (__main__.TestVPP.test_16_vpp_cgnat) ... ok
test_17_vpp_nat (__main__.TestVPP.test_17_vpp_nat) ... ok
test_18_vpp_vrrp (__main__.TestVPP.test_18_vpp_vrrp) ... ok

----------------------------------------------------------------------
Ran 20 tests in 389.855s

OK (skipped=3)
[edit]

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@natali-rs1985 natali-rs1985 marked this pull request as draft July 30, 2025 10:49
@natali-rs1985 natali-rs1985 force-pushed the T7577 branch 3 times, most recently from 5d2abb1 to e92019d Compare July 31, 2025 10:15
@natali-rs1985 natali-rs1985 marked this pull request as ready for review July 31, 2025 10:17
CLI commands:
set vpp vrrp group FIRST address <192.0.2.1> # multi
set vpp vrrp group FIRST interface <eth1>
set vpp vrrp group FIRST vrid <10>
set vpp vrrp group FIRST priority <100>
set vpp vrrp group FIRST peer-address <192.0.2.12> # multi
set vpp vrrp group FIRST advertise-interval <100>
set vpp vrrp group FIRST no-preempt
set vpp vrrp group FIRST accept-mode
set vpp vrrp group FIRST disable
set vpp vrrp group FIRST description <test>
@dmbaturin
Copy link
Contributor

There's no immediate need for this since the normal VRRP through Keepalived works just fine. We may need to get back to it if it stops working.

So, we'll close the PR now, just not to keep it open, but the code is mothballed, not rejected.

@dmbaturin dmbaturin closed this Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants