Skip to content

Conversation

evanp
Copy link
Collaborator

@evanp evanp commented Nov 1, 2023

Add an erratum for the core document that gives a full list of the properties of a link, except href, to correct section 4.2.

Add an erratum for the core document that gives a full list of the properties of a link, except `href`, to correct section 4.2.
@nightpool
Copy link
Collaborator

not 100% convinced that nameMap should be included here since it's not specified as a property in https://www.w3.org/TR/activitystreams-vocabulary. It's more of a syntax thing that's applicable for any rdf:langString typed property. The other two LGTM though

@nightpool
Copy link
Collaborator

I guess we do give nameMap and summaryMap in the symmetrical Object definition in 4.1 though so it's weird to omit here.

@dariusk
Copy link

dariusk commented Aug 22, 2025

More explicit is good as far as I'm concerned. I like it

Copy link

@snarfed snarfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -4,7 +4,8 @@ This document includes errata for the [Activity Streams](https://www.w3.org/TR/a

## Activity Streams

- None yet reported.
- Section 4.2 lists the possible properties of a `Link` object. This list omits `nameMap`, `preview`, `attributedTo`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Section 4.2 lists the possible properties of a `Link` object. This list omits `nameMap`, `preview`, `attributedTo`
- Section 4.2 lists the possible properties of a `Link` object. This list omits `nameMap`, `preview`, and `attributedTo`.

@@ -4,7 +4,8 @@ This document includes errata for the [Activity Streams](https://www.w3.org/TR/a

## Activity Streams

- None yet reported.
- Section 4.2 lists the possible properties of a `Link` object. This list omits `nameMap`, `preview`, `attributedTo`
The full list should be: id | name | nameMap | hreflang | mediaType | rel | height | width | preview | attributedTo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The full list should be: id | name | nameMap | hreflang | mediaType | rel | height | width | preview | attributedTo.
The full list should be: `id | name | nameMap | hreflang | mediaType | rel | height | width | preview | attributedTo`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants