Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move function into preProcess #240

Merged
merged 1 commit into from
Jan 20, 2021
Merged

move function into preProcess #240

merged 1 commit into from
Jan 20, 2021

Conversation

deniak
Copy link
Member

@deniak deniak commented Jan 20, 2021

move functions into preprocess

@deniak deniak requested a review from r12a January 20, 2021 11:00
@r12a r12a merged commit 4db5868 into gh-pages Jan 20, 2021
@r12a
Copy link
Contributor

r12a commented Jan 20, 2021

Unfortunately, there's no improvement. https://www.w3.org/TR/2021/WD-alreq-gap-20210120/#bidi_text

I must say, that seems odd, if the scripts are run before the general respec code, since the structure of the document looks ok, it's just the bits that should be sucked in from GH issues that are missing.

Could there be a caching problem snarling things up?

@r12a
Copy link
Contributor

r12a commented Jan 20, 2021

Note that it works fine for the ED and from my hard drive. It is also adding the italicised prompts, which are read in from a separate file with a relative link. It's just the GH issue data that's not appearing. It's not an origin problem associated with the build code, is it?

@r12a
Copy link
Contributor

r12a commented Jan 20, 2021

Or perhaps it's just down to the delay incurred in obtaining the data during the build of the doc by the spec-generator? For example, when the page works as expected in the ED or from the hard drive there can be a 1-2 second delay before the GH issue text appears in the document.

@deniak deniak deleted the preprocess branch January 20, 2021 12:52
@deniak
Copy link
Member Author

deniak commented Jan 20, 2021

After more investigation, the issue comes from the github issue fetching. All the calls are asynchronous and respec doesn't wait for them to finish.
I've refactored the script a little bit: w3c/i18n-activity#1009
This should fix the issue.

@r12a
Copy link
Contributor

r12a commented Jan 20, 2021

@denis it hasn't fixed the issue yet, see https://www.w3.org/TR/alreq-gap/#bidi_text but i'm inclined to suspect that this may be because the real latest version is not being served because of caching?

I get a console message "XHR GET https://www.w3.org/TR/tr-outdated-spec Not found" when trying to load https://www.w3.org/TR/2021/WD-alreq-gap-20210120/

I may try to republish another page and see whether that breaks...

@r12a
Copy link
Contributor

r12a commented Jan 20, 2021

Actually, https://labs.w3.org/spec-generator/?type=respec&url=https%3A%2F%2Fw3c.github.io%2Falreq%2Fgap-analysis%2F%3FspecStatus%3DWD%26shortName%3Dalreq-gap#bidi_text is still producing intermittent failures, too (although it works more often than it fails, this time, which is the opposite of what we had before).

@deniak
Copy link
Member Author

deniak commented Jan 21, 2021

I tried to debug and I believe the bug comes from respec (see https://github.com/w3c/respec/issues/3273)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants