Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add ESLint Plugins #341

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 20, 2020

Preview Tests

Causes a big diff now, but has the same setup as aria-practices, so should make the syncing in #339 easier

@nschonni
Copy link
Contributor Author

@howard-e before I try and rebase this one, is this something you folks are already working on?

@howard-e
Copy link
Contributor

howard-e commented Feb 17, 2022

@howard-e before I try and rebase this one, is this something you folks are already working on?

You can go ahead @nschonni!

@nschonni nschonni force-pushed the eslint-improvements branch from 7424f54 to d3350fe Compare February 17, 2022 18:33
@nschonni
Copy link
Contributor Author

The original commit was mostly done by another PR, but adding the node plugin started to lint the MJS files, that I guess were skipped right now

@nschonni nschonni force-pushed the eslint-improvements branch from 5f208bb to bedad47 Compare March 15, 2022 19:47
@netlify
Copy link

netlify bot commented Mar 15, 2022

Deploy Preview for aria-at failed.

Name Link
🔨 Latest commit 2cf0083
🔍 Latest deploy log https://app.netlify.com/sites/aria-at/deploys/624343551f0d100008b78c5d

@howard-e
Copy link
Contributor

Not sure why that's failing for you @nschonni. Taking a look.

@howard-e
Copy link
Contributor

howard-e commented Mar 15, 2022

Ahh, seems some code updates are missing.

@nschonni
Copy link
Contributor Author

Trying another rebase/bump

@nschonni nschonni force-pushed the eslint-improvements branch from bedad47 to d2ec282 Compare March 15, 2022 20:07
@nschonni nschonni marked this pull request as draft March 16, 2022 20:13
@nschonni nschonni force-pushed the eslint-improvements branch from d2ec282 to 05dba76 Compare March 29, 2022 17:28
@nschonni nschonni force-pushed the eslint-improvements branch from 05dba76 to 2cf0083 Compare March 29, 2022 17:35
@nschonni
Copy link
Contributor Author

Interesting, got an error when setting the compat to >=12 The 'fs.rmSync' is not supported until Node.js 14.14.0. The configured version range is '>=12' in create-example-tests.js

@howard-e
Copy link
Contributor

Interesting, got an error when setting the compat to >=12 The 'fs.rmSync' is not supported until Node.js 14.14.0. The configured version range is '>=12' in create-example-tests.js

Good catch. Since this project already makes use of rimraf, that line could be safely replaced with rimraf.sync(path.join(sourceFolder, file));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants