-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add ESLint Plugins #341
base: master
Are you sure you want to change the base?
Conversation
@howard-e before I try and rebase this one, is this something you folks are already working on? |
7424f54
to
d3350fe
Compare
The original commit was mostly done by another PR, but adding the node plugin started to lint the MJS files, that I guess were skipped right now |
5f208bb
to
bedad47
Compare
❌ Deploy Preview for aria-at failed.
|
Not sure why that's failing for you @nschonni. Taking a look. |
Ahh, seems some code updates are missing. |
Trying another rebase/bump |
bedad47
to
d2ec282
Compare
d2ec282
to
05dba76
Compare
05dba76
to
2cf0083
Compare
Interesting, got an error when setting the compat to >=12 |
Good catch. Since this project already makes use of |
Preview Tests
Causes a big diff now, but has the same setup as aria-practices, so should make the syncing in #339 easier