[css-view-transitions-2] Allow auto as a keyword
#10922
Open
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`auto` resolves to either the element's ID, or to a unique identifier that is stable for the duration of the transition and is not web-observable. Resolution: w3c#8320 (comment) Closes w3c#8320
| @@ -755,7 +755,20 @@ div.box { | |||
|
|
|||
| # Nested view-transitions # {#nested-view-transitions} | |||
|
|
|||
| ## Overview ## {#nested-overview} | |||
| ## Overview ## {#auto-name-overview} | |||
There was a problem hiding this comment.
Why is this under Nested view-transitions? Doesn't have anything to do with that feature. Looks like you inadvertently overrode the overview for nested view-transitions..?
| 1. If |computed| is a <<custom-ident>>, return |computed|. | ||
| 1. Assert: |computed| is <css>auto</css>. | ||
| 1. If |element| has an associated [=Element/id=], then return |element|'s [=Element/id=]. | ||
| 1. Return a unique string, which is not a <<custom-ident>>. This string should remain consistent at least for the lifetime of |element|'s [=node document=]'s [=active view transition=]. |
There was a problem hiding this comment.
I'm not sure how exactly to reword this but a couple of things are not obvious right now:
- The string needs to uniquely identify the element. Right now it's ambiguous whether we mean unique for that specific transition.
- For the cross-doc case, this sounds like any
autoelement without an id will become an exit animation since there won't be a match in the new Document. Is that the intention? If so, the string should remain unique even the document changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoresolves to either the element's ID, or to a unique identifier that is stable for the duration of the transition and is not web-observable.Resolution: #8320 (comment)
Closes #8320