-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scroll-animations-1] Add examples #11421
Conversation
I believe this PR is ready for review. One thing I struggled with is there to place the examples for If I were an author, I would like to see the examples that use As a result, though, the section itself might need some rewording / extra sentences which I can tackle later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That should not hold up merging this PR however |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. General comment is, the goal of example text is to step away from the spec's precision and generality and help the reader see concretely what it does, using the example as an illustration of what the spec means in more practical and illustrative terms.
Co-authored-by: fantasai <[email protected]>
Co-authored-by: fantasai <[email protected]>
Co-authored-by: fantasai <[email protected]>
Co-authored-by: fantasai <[email protected]>
…instances per match
Addressed the comments. Re-requesting a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over the PR with @fantasai. Added remarks together for me to resolve.
@fantasai I believe I have addressed the open issues regarding this PR, by more describing the visual outcome of the examples. PTAL. I’m tinkering with some faux animations – e.g. https://codepen.io/bramus/pen/LEPwzrL/d5c60ce4645de7aa11abae28db79288c - but suggest on adding those later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the examples and details. This will be really helpful.
Add some examples to the scroll-animations-1 spec.