Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-mixins-1] Fix build error #11585

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[css-mixins-1] Fix build error #11585

wants to merge 3 commits into from

Conversation

bramus
Copy link
Contributor

@bramus bramus commented Jan 28, 2025 •
edited
Loading

This PR fixes the following two issues with the css-mixins-1 spec:

  • Build errors when building the spec, caused by rogue </pre> tags.
  • Add the opening paren after @function. I believe this was erroneously removed in fe94b66.

@bramus bramus requested review from andruud and tabatkins and removed request for andruud January 28, 2025 00:03
andruud
andruud reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@andruud andruud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the commit title explained what the fix is.

css-mixins-1/Overview.bs Outdated Show resolved Hide resolved
@bramus bramus changed the title [css-mixins-1] Fix mixins spec [css-mixins-1] Fix build error Jan 28, 2025
@bramus
Copy link
Contributor Author

bramus commented Jan 28, 2025 •
edited
Loading

It would be nice if the commit title explained what the fix is.

Reverted the incorrect commit + adjusted the title of the PR.

@bramus bramus requested a review from andruud January 28, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabatkins tabatkins Awaiting requested review from tabatkins

@andruud andruud Awaiting requested review from andruud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bramus @andruud