-
Notifications
You must be signed in to change notification settings - Fork 706
[css-images-4] Add the use of “longer” hue interpolation for the color wheel in the example #11755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r wheel in the example Fix w3c#1222
a75f3e6
to
977edc9
Compare
@tabatkins @LeaVerou PTAL |
yisibl marked as non substantive for IPR from ash-nazg. |
width: 200px; height: 200px; | ||
</pre> | ||
|
||
<img src="images/conic5.png" alt="color wheel"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should.
The rendering in Firefox (on Win, at least) also shows a rendering bug, but that is a separate issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svgeesus You wrote:
The rendering in Firefox (on Win, at least) also shows a rendering bug, but that is a separate issue
It looks OK to me on my Windows machine. Could you clarify what rendering bug you're seeing, please? (Or file a bug at https://bugzilla.mozilla.org with details.) Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should.
@svgeesus Okay, I'll modify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK to me on my Windows machine. Could you clarify what rendering bug you're seeing, please?
https://codepen.io/svgeesus/pen/KwKzgQE
Nightly 137.0a1 (2025-02-26) (64-bit) Windows 11
Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1951113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could add that image to the PR (separate filename, in case it is also used elsewhere) that would be helpful.
width: 200px; height: 200px; | ||
</pre> | ||
|
||
<img src="images/conic5.png" alt="color wheel"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should.
The rendering in Firefox (on Win, at least) also shows a rendering bug, but that is a separate issue
<pre class=lang-css> | ||
background: radial-gradient(closest-side, gray, transparent), | ||
conic-gradient(in hsl longer hue, red 0 100%); | ||
transform: scaleX(-1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird, we should just flip the image instead and go with a standard rainbow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of color pickers that use a counterclockwise rainbow, can we consider adding a related keyword to the gradient to change the direction of rotation?(I can file a new issue.)
That way we no longer need scaleX(-1)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always just reverse your color stops. That won't work for this particular rainbow example (you'll have to add some additional stops instead), but that's fine; using longer hue
specifically to generate rainbows is something that's neat but not intentionally supported as a feature.
Fix #1222