Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw error on non-2XX returned from github api #1010

Closed
wants to merge 1 commit into from
Closed

throw error on non-2XX returned from github api #1010

wants to merge 1 commit into from

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Jan 20, 2021

quick hack for #1009 (comment)
(hope to work...)

@himorin himorin requested review from deniak and r12a January 20, 2021 14:11
r12a added a commit that referenced this pull request Jan 20, 2021
@r12a
Throw error on non-2XX returned from github api
7202d8e 
provided by @himorin at #1010 but added in this commit because large amounts of reformatting of the file had introduced conflicts since the original PR was submitted
@r12a
Copy link
Contributor

r12a commented Jan 20, 2021

Thanks @himorin. Added as 7202d8e to avoid conflicts.

@r12a r12a closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniak deniak deniak approved these changes

@r12a r12a Awaiting requested review from r12a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himorin @r12a @deniak