Update the encoder api and config to not utilize IFTB patches as inputs #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oes not rely on IFTB.
- Design space segmentation not yet supported.
garretrieger
force-pushed
the
encoder_update
branch
from
ca621ba to
937f7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the encoder was configured by giving it a set of IFTB patches from which it would extract a segmentation plan. This change removes the dependency on IFTB and instead allows the encoder to be configured by describing the desired segmentation.
This replaces the IFTB specific apis on Encoder with more generic ones. Additionally the font2ift command line utility has been updated to take an encoder configuration as a textproto file instead of being configured with a large set of command line flags.
Lastly, this includes a migration from WORKSPACE to bazelmod which was needed to get the updated font2ift to compile correctly.