Fix IDL definition of LoadDocumentCallback
#664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dictionary arguments cannot be nullable in Web IDL: > "Although dictionary types can in general be nullable, they cannot when used as the type of an operation argument or a dictionary member." > https://webidl.spec.whatwg.org/#dfn-nullable-type Note: this was missed before because the webidl2 checker did not validate arguments in callback definitions. It now does.
|
Thanks, although this may be a controversial opinion, I think it is low-enough impact to be considered a class-2 change. |
gkellogg
approved these changes
Jul 24, 2025
dlongley
approved these changes
Jul 25, 2025
pchampin
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictionary arguments cannot be nullable in Web IDL:
Note: this was missed before because the webidl2 checker did not validate arguments in callback definitions. It now does.
Preview | Diff