Skip to content

Suggestions from January review on §3.4 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Apr 23, 2025

@pchampin pchampin added spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial labels Apr 23, 2025
@pchampin pchampin requested review from gkellogg, afs and hartig April 23, 2025 23:58
@@ -791,7 +791,7 @@ <h3>Literals</h3>
<p>Literals are used for values such as strings, numbers, and dates.</p>

<p>A <dfn data-local-lt="RDF literal">literal</dfn> in an <a>RDF graph</a> consists of
two, three, or four elements, as follow:</p>
two, three, or four component elements, as follows:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion ("component elements" sounds a bit weird to me):

Suggested change
two, three, or four component elements, as follows:</p>
two, three, or four components, as follows:</p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afs suggested "component elements", so that's what I wrote.
"component" works for me. @afs? @gkellogg?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweak.

      two, three, or four components, as follow:</p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallTed the change from "as follow" to "as follows" was suggested by @bobdc, and makes sense to me because

  • everywhere else, we use "as follows"
  • my understanding, confirmed by a quick web search, is that "as follows" is grammatically correct, while "as follow" is not

Any argument in the defense of "as follow"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are differing opinions on this bit of grammar. To my ear, follow sounds better after a plural antecedent. I think the best solution would be to change follow(s) to below, for which there is no belows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"components" is also used as "The three components (s, p, o) of an RDF triple. "component element" is an attempt to distinguish the usage at this point then continue using "element" in the rest of the next. It leaves "element" in the rest of the section alone.

If its one word "component" here the rest of the section needs updating as well. "if the third element is present" etc.

Co-authored-by: Olaf Hartig <[email protected]>
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with my additional suggested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants