-
Notifications
You must be signed in to change notification settings - Fork 4
Suggestions from January review on §3.4 #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bob DuCharme's 9th comment https://www.w3.org/mid/[email protected]
Bob DuCharme's 11th comment https://www.w3.org/mid/[email protected]
@@ -791,7 +791,7 @@ <h3>Literals</h3> | |||
<p>Literals are used for values such as strings, numbers, and dates.</p> | |||
|
|||
<p>A <dfn data-local-lt="RDF literal">literal</dfn> in an <a>RDF graph</a> consists of | |||
two, three, or four elements, as follow:</p> | |||
two, three, or four component elements, as follows:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion ("component elements" sounds a bit weird to me):
two, three, or four component elements, as follows:</p> | |
two, three, or four components, as follows:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweak.
two, three, or four components, as follow:</p>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TallTed the change from "as follow" to "as follows" was suggested by @bobdc, and makes sense to me because
- everywhere else, we use "as follows"
- my understanding, confirmed by a quick web search, is that "as follows" is grammatically correct, while "as follow" is not
Any argument in the defense of "as follow"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are differing opinions on this bit of grammar. To my ear, follow
sounds better after a plural antecedent. I think the best solution would be to change follow(s)
to below
, for which there is no belows
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"components" is also used as "The three components (s, p, o) of an RDF triple. "component element" is an attempt to distinguish the usage at this point then continue using "element" in the rest of the next. It leaves "element" in the rest of the section alone.
If its one word "component" here the rest of the section needs updating as well. "if the third element is present" etc.
Co-authored-by: Olaf Hartig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with my additional suggested change.
Preview | Diff