-
Notifications
You must be signed in to change notification settings - Fork 8
change definition of rdf:JSON #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Better would be
with a note just after saying,
This makes the definition correct with respect to JSON objects while retaining the potential use of INFRA. |
@pfps — Can you make your comment(s) as a "suggested change" through the GitHub UI? It will be much easier to review the line(s) you're suggesting be added or changed, in the immediate context of the line(s) you're suggesting be changed or removed. |
How can I make a suggested change to a place in the document that is not being changed? |
"View the document" and click on the line number you want to discuss. Then ctrl-click on it. You'll get a menu of options, at least one of which should be relevant. (Probably you don't want to create a new issue, but you can just copy the link to the line, so we know what your suggested "Better would be" change should be applied to ... which is unknowable as things stand. ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the small grammar change I suggested. I think @pfps suggestion is also useful to not completely throw people off who believe JSON objects are unordered.
spec/index.html
Outdated
@@ -1931,6 +1902,9 @@ <h3>The <code>rdf:JSON</code> Datatype</h3> | |||
</ul> | |||
</dd> | |||
</dl> | |||
<p class="note"> | |||
The constraint to order map entries in the value space is only meant to make the order of object-member the lexical space irrelevant. In other word, it ensures that both lexical values <code>{"a": "b", "c": "d"}</code> and <code>{"c": "d", "a": "b"}</code> are mapped to the same element of the value space. Implementations may omit to sort the entries, as long as they treat the maps in the value space as unordered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constraint to order map entries in the value space is only meant to make the order of object-member the lexical space irrelevant. In other word, it ensures that both lexical values <code>{"a": "b", "c": "d"}</code> and <code>{"c": "d", "a": "b"}</code> are mapped to the same element of the value space. Implementations may omit to sort the entries, as long as they treat the maps in the value space as unordered. | |
The constraint to order map entries in the value space is only meant to make the order of map entries in the lexical space irrelevant. In other words, it ensures that both lexical values <code>{"a": "b", "c": "d"}</code> and <code>{"c": "d", "a": "b"}</code> are mapped to the same element of the value space. Implementations may omit to sort the entries, as long as they treat the maps in the value space as unordered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the lexical space is made of strings, not of maps... So technically, there are no map entries in the lexical space. "object member" refers to the terms in the JSON grammar, and therefore is more appropriate for talking about the lexical space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that, "object-member" should have been plural, and indeed "word" as well... This is fixed in 215a18e .
Co-authored-by: Gregg Kellogg <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Peter F. Patel-Schneider <[email protected]>
to try and solve #116
Preview | Diff