Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown variable #1765

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix unknown variable #1765

merged 1 commit into from
Feb 4, 2025

Conversation

Que-tin
Copy link
Contributor

@Que-tin Que-tin commented Feb 3, 2025

I'm not quite sure where plain "engines" should be coming from when looking into this file. I'm pretty sure it needs to be packageConfig.engines otherwise I can't even run the script on my machine.

This probably hasn't been noticed before, as everyone ran the script with the correct version.

I'm not quite sure where plain "engines" should be coming from when looking into this file. I'm pretty sure it needs to be `packageConfig.engines` otherwise I can't even run the script on my machine.
@dontcallmedom dontcallmedom requested a review from tidoust February 4, 2025 08:47
@tidoust tidoust merged commit fafdb65 into w3c:main Feb 4, 2025
1 check passed
tidoust added a commit that referenced this pull request Feb 4, 2025
Bug fixed:
- Fix unknown variable (#1765)

Dependencies bumped:
- Bump rollup from 4.31.0 to 4.34.2 (#1766)
- Bump puppeteer from 24.1.0 to 24.1.1 (#1759)
- Bump semver from 7.6.3 to 7.7.1 (#1767)
- Bump mocha from 11.0.1 to 11.1.0 (#1757)
- Bump undici from 7.2.3 to 7.3.0 (#1756)
- Bump web-specs from 3.35.0 to 3.37.0 (#1763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants