Dfns extraction: expand logic that skips imported definitions #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crawler expected "imported definitions" to use `<dfn>` as the wrapping element with an inner `<a>` element. The Source map format spec now uses the opposite pattern. This update expands the logic accordingly. Close #1788.
|
since the upstream spec has been changed, I wonder if it's still worth merging this? did you check if it would generate true and/or false positives? |
|
No false positives generated! Don't you trust our test suite? 😲 And it's actually useful as it captures two cases of that same pattern used in other specs:
|
dontcallmedom
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crawler expected "imported definitions" to use
<dfn>as the wrapping element with an inner<a>element. The Source map format spec now uses the opposite pattern. This update expands the logic accordingly.Close #1788.