Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken references #390

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix broken references #390

merged 1 commit into from
May 24, 2024

Conversation

clelland
Copy link
Contributor

@clelland clelland commented May 24, 2024

Fixes a few broken refs: "default toJSON operation", Performance and navigation timing startTime refs.
Closes: #376


Preview | Diff

Fixes a few broken refs: "default toJSON operation", Performance and navigation timing startTime refs.
Closes: #376
@clelland clelland requested a review from yoavweiss May 24, 2024 18:26
example, the <a data-cite=
"NAVIGATION-TIMING-2#dom-PerformanceNavigationTiming-startTime">start
since the start of navigation of the document [[HR-TIME]]. For
example, the <a data-cite="NAVIGATION-TIMING-2#performanceentry">start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the "-2" on NavTiming?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, unfortunately. [[NAVIGATION-TIMING]] on it own directs to a 2012 REC-level version of the spec. See https://www.specref.org/?q=navigation%20timing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caribouW3 - is this something we can fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specref has a [navigation-timing-2] entry.
It'd be nice to advance Navigation Timing to CR, though (wide review has not been done yet, AFAIK)

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clelland clelland merged commit 0966a60 into gh-pages May 24, 2024
2 checks passed
@clelland clelland deleted the fix-refs-1 branch May 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken references in Resource Timing
3 participants