Add run in docker instructions #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <[email protected]>
BigBlueHat
requested changes
Feb 13, 2025
There was a problem hiding this comment.
@PatStLouis can you add something to the main README about how to use this? Or link to docker/README.md from there?
Also a few nits and questions.
Co-authored-by: BigBlueHat <[email protected]>
Co-authored-by: BigBlueHat <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
BigBlueHat
reviewed
Mar 4, 2025
| @@ -0,0 +1,38 @@ | |||
| --- | |||
| configs: | |||
| implementation.json: | |||
There was a problem hiding this comment.
Given how you're doing the localConfig.cjs above, is this file still needed?
Guess I'm getting lost among all the nesting dolls...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a docker-compose file and some instructions.
This enables implementers to run all test suites against their implementation instead of having to clone individual repositories. This is similar to run against a local instance.