-
Notifications
You must be signed in to change notification settings - Fork 21
Check implementation ZCAP expirations. #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this will be an annoyance when it happens. Any expired zcap will block all merges?
Perhaps this test could be run as a different job that would show the error but not block?
It looks like for this to work, someone with Admin privileges on this repo (not me...) will have to configure which tests will block the build. The most I can do at this point is separate the test out and run it as a separate GitHub Workflow so it could be avoided (by someone with those settings). That said, it's still possible to push through a PR (for folks with the right permission levels...like me in this case), even if the ZCAPs are expired and that test fails. So...it sadly feels easier/more obvious to leave it as it is--so at least the warnings/errors won't get overlooked even if they have to be pushed past in some cases. |
ee4d985
to
b7b0f50
Compare
@davidlehn the build will no longer be blocked. Pretty certain these will just get overlooked again, though...but at least if someone checks the logs they'll see the info. |
@tminard I added a new test here to check |
Zizmor recommendations.
We do not want to block the build, only report. However, these will likely get missed now...but at least someone can check the logs...
83e4169
to
3852c59
Compare
The goal of this PR is to avoid expired ZCAPs from sneaking up on anyone. The tests will fail if a ZCAP capability expires a month from the test run. Tests are run once every Thursday morning (3 days before test suites run on Sunday mornings).