Factor "obtain a lock manager" out of algorithms #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saschanaz - one more for you to look at, at your leisure? Thank you for all your help! |
saschanaz
approved these changes
Nov 12, 2021
github-actions bot
added a commit
that referenced
this pull request
Nov 12, 2021
SHA: 0d1d24e Reason: push, by @inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More factoring of logic out of #75 - this pulls the logic for obtaining a lock manager (or failing for opaque origins) out of call sites into a new set of steps, taking an environment as input. This sets us up for the later work to support partitioning.
A few other tiny wording/syntax tweaks are included as well, but there are no intended normative behavior changes.
Preview | Diff