Add input.SetFiles
#514
Merged
Add input.SetFiles
#514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Aug 23, 2023
OrKoN
reviewed
Aug 23, 2023
Contributor
|
@jgraham @whimboo @juliandescottes PTAL Perhaps you have suggestions for the open discussions and some other suggestions. |
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
4 times, most recently
from
6b6ea1b to
22e6df6
Compare
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
4 times, most recently
from
241213b to
4c827b8
Compare
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
from
4c827b8 to
caffe23
Compare
jrandolf-google
changed the base branch from
main
to
jrandolf/file-dialog-opened
OrKoN
reviewed
Nov 8, 2023
OrKoN
reviewed
Nov 8, 2023
OrKoN
reviewed
Nov 8, 2023
jgraham
reviewed
Nov 8, 2023
OrKoN
reviewed
Nov 8, 2023
jrandolf-google
force-pushed
the
jrandolf/file-dialog-opened
branch
from
3bd59bb to
e31b876
Compare
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
3 times, most recently
from
e24c9dc to
f350765
Compare
OrKoN
force-pushed
the
jrandolf/file-dialog-opened
branch
2 times, most recently
from
5421b69 to
4e766f5
Compare
OrKoN
force-pushed
the
jrandolf/set-files
branch
from
921398a to
a1e64ec
Compare
Contributor
|
Looks like this PR stalled a bit. @jrandolf mind giving a quick update what's the status? |
Contributor
Author
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
from
ae3af76 to
992e9f1
Compare
jrandolf-google
changed the base branch from
jrandolf/file-dialog-opened
to
main
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
from
992e9f1 to
da5beb0
Compare
whimboo
reviewed
Jan 8, 2024
Co-authored-by: Alex Rudenko <[email protected]>
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
3 times, most recently
from
d47c6c8 to
326b073
Compare
whimboo
reviewed
Jan 11, 2024
Co-authored-by: Henrik Skupin <[email protected]>
jrandolf-google
force-pushed
the
jrandolf/set-files
branch
from
326b073 to
69ffc1a
Compare
jgraham
approved these changes
Jan 12, 2024
jgraham
reviewed
Jan 12, 2024
Co-authored-by: jgraham <[email protected]>
Contributor
|
@jrandolf are you planning to write necessary wpt tests for this new feature? |
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #494
File dialog PR: #568
Preview | Diff