Always handle subscription IDs in session.unsubscribe if provided#867
Merged
Always handle subscription IDs in session.unsubscribe if provided#867
Conversation
Contributor
juliandescottes
left a comment
juliandescottes
left a comment
There was a problem hiding this comment.
Overall looks good to me, but it makes the algorithm a bit harder to follow (see comment). Would still like to make sure that @jgraham is fine with this as well.
jgraham
approved these changes
Jan 23, 2025
github-actions bot
added a commit
that referenced
this pull request
Jan 24, 2025
SHA: 1d0fcc1 Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Always handle subscription IDs in session.unsubscribe if provided * add a note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff