Do not use request's window concept#918
Merged
Conversation
Per whatwg/fetch#1823, this concept is going away. Instead, use the request's client, which is equivalent for this spec's purposes.
13 tasks
OrKoN
reviewed
May 13, 2025
OrKoN
approved these changes
May 14, 2025
jgraham
approved these changes
May 14, 2025
Member
jgraham
left a comment
jgraham
left a comment
There was a problem hiding this comment.
Thanks for the explanation, this makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per whatwg/fetch#1823, this concept is going away. Instead, use the request's client, which is equivalent for this spec's purposes.
This needs careful review by experts as, unlike almost all other update PRs linked from whatwg/fetch#1823, it's possible that WebDriver BiDi actually does care about the distinction between client and window. But, I think this change is correct.
Preview | Diff